Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Adds datetime parsing to Request instance #39945

Merged
merged 12 commits into from
Dec 17, 2021
Merged

[8.x] Adds datetime parsing to Request instance #39945

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
09eaec1
Parses datetime from request input.
DarkGhostHunter Dec 8, 2021
323c2f7
Fixes style and tests.
DarkGhostHunter Dec 8, 2021
2fbc401
Adds support for default value (like "now").
DarkGhostHunter Dec 8, 2021
c49469f
Style fixes.
DarkGhostHunter Dec 8, 2021
51a9918
Removes default and adds false to invalid datetimes.
DarkGhostHunter Dec 9, 2021
f68bc77
Stabilize returns types when dealing with invalid dates.
DarkGhostHunter Dec 9, 2021
ee29dfb
Minor test formatting to push tests on GitHub.
DarkGhostHunter Dec 9, 2021
a31c4f3
Shortened function name to `date()`.
DarkGhostHunter Dec 11, 2021
993cb1a
Restores exception handling. Trust your instincts.
DarkGhostHunter Dec 15, 2021
2ee3936
Style fixes and method fixes.
DarkGhostHunter Dec 15, 2021
8578b56
formatting
taylorotwell Dec 16, 2021
e394e89
Style fixes.
DarkGhostHunter Dec 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Style fixes.
  • Loading branch information
@DarkGhostHunter
DarkGhostHunter committed Dec 8, 2021
commit c49469f46f027caf0e9b5d4e189cb4539ed7bb1a
2 changes: 0 additions & 2 deletions src/Illuminate/Http/Concerns/InteractsWithInput.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@
use stdClass;
use Symfony\Component\VarDumper\VarDumper;

use function is_null;

trait InteractsWithInput
{
/**
Expand Down
6 changes: 2 additions & 4 deletions tests/Http/HttpRequestTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@
use Symfony\Component\HttpFoundation\File\UploadedFile as SymfonyUploadedFile;
use Symfony\Component\HttpFoundation\Request as SymfonyRequest;

use function now;

class HttpRequestTest extends TestCase
{
protected function tearDown(): void
Expand Down Expand Up @@ -546,15 +544,15 @@ public function testDatetimeMethod()
'as_timezone' => '20-01-01 13:30:25',
]);

$current = Carbon::create(2020, 1, 1,16,30,25,'UTC');
$current = Carbon::create(2020, 1, 1, 16, 30, 25, 'UTC');

$this->assertNull($request->datetime('as_null'));
$this->assertNull($request->datetime('doesnt_exists'));
$this->assertTrue($request->datetime('as_date')->isSameDay($current));
$this->assertEquals($current, $request->datetime('as_datetime'));
$this->assertTrue($request->datetime('as_time')->isSameSecond('16:30:25'));
$this->assertEquals($current, $request->datetime('as_format', 'U'));
$this->assertEquals($current, $request->datetime('as_timezone', null, 'America/Santiago'));
$this->assertEquals($current, $request->datetime('as_timezone', null, 'America/Santiago'));

Carbon::setTestNow($current);

Expand Down