[9.x] Refactor ExceptionHandler render method #39930
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem?
For years, a bunch of features such as render check and Responsable check have been added to the ExcepionHandler render method. The latest thing is render callbacks registration. Because of them, the ExcepionHandler render method becomes giant and messy. I think it's time to refactor this method, so it will be easier to read and maintain.
What do I do?
In this MR, I've done three things:
How is it improved?
The ExcepionHandler render method now has a clear logic in this order:
This is a quick overview of the final method: