[8.x] Adds support for pusher/pusher-php-server: ^7.0
#39632
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nunomaduro maybe we can already drop/remove some of them in Laravel 9? |
|
@driesvints Agree. @taylorotwell would you be ok having make Laravel 9 "pusher-php-server: ^7.0" only? There is no reason why would keep supporting those old versions, and is a good moment to add a note to the upgrade guide. If yes, you can merge this one, and I will work in a different pull request for Laravel 9. |
X-Coder264
reviewed
Nov 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for
pusher/pusher-php-server: ^7.0. Note that, at this point, we are using a few deprecated methods, such as$this->pusher->socket_auth(..., etc. They will still work for now, but i guess they will be removed on^8.0.