[8.x] Introduce @js() directive
#39522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I approve this message |
I have just noticed that in a project using Laravel 9.7.0 and Livewire 2.10.5 the Livewire @js directive seems to take precedence over the framework implementation. Following this PR, which states that Livewire should not register its directive on Laravel 8.71.0+, it seems like this is not the intended behavior? @calebporzio Can you confirm this? |
|
I opened a discussion at livewire/livewire#4875 with more details as this seems to be an issue of Livewire rather than Laravel. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebased version of #39478 that I'm resubmitting after a conversation with @calebporzio. If this gets merged, either he or I can add a
version_comparecheck to Livewire that would only register the existing Livewire directive for Laravelv8.69.0and lower (or whatever release is one below the version this ended up in).