Skip to content

[9.x] Removes opis/closure package #39087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 5, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
"league/flysystem": "^2.0",
"monolog/monolog": "^2.0",
"nesbot/carbon": "^2.31",
"opis/closure": "^3.6",
"psr/container": "^1.1.1|^2.0.1",
"psr/log": "^1.0|^2.0",
"psr/simple-cache": "^1.0",
Expand Down
8 changes: 4 additions & 4 deletions src/Illuminate/Bus/PendingBatch.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@
use Illuminate\Bus\Events\BatchDispatched;
use Illuminate\Contracts\Container\Container;
use Illuminate\Contracts\Events\Dispatcher as EventDispatcher;
use Illuminate\Queue\SerializableClosureFactory;
use Illuminate\Support\Arr;
use Illuminate\Support\Collection;
use Laravel\SerializableClosure\SerializableClosure;
use Throwable;

class PendingBatch
Expand Down Expand Up @@ -78,7 +78,7 @@ public function add($jobs)
public function then($callback)
{
$this->options['then'][] = $callback instanceof Closure
? SerializableClosureFactory::make($callback)
? new SerializableClosure($callback)
: $callback;

return $this;
Expand All @@ -103,7 +103,7 @@ public function thenCallbacks()
public function catch($callback)
{
$this->options['catch'][] = $callback instanceof Closure
? SerializableClosureFactory::make($callback)
? new SerializableClosure($callback)
: $callback;

return $this;
Expand All @@ -128,7 +128,7 @@ public function catchCallbacks()
public function finally($callback)
{
$this->options['finally'][] = $callback instanceof Closure
? SerializableClosureFactory::make($callback)
? new SerializableClosure($callback)
: $callback;

return $this;
Expand Down
22 changes: 0 additions & 22 deletions src/Illuminate/Encryption/EncryptionServiceProvider.php
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
use Illuminate\Support\ServiceProvider;
use Illuminate\Support\Str;
use Laravel\SerializableClosure\SerializableClosure;
use Opis\Closure\SerializableClosure as OpisSerializableClosure;

class EncryptionServiceProvider extends ServiceProvider
{
Expand All @@ -17,7 +16,6 @@ class EncryptionServiceProvider extends ServiceProvider
public function register()
{
$this->registerEncrypter();
$this->registerOpisSecurityKey();
$this->registerSerializableClosureSecurityKey();
}

Expand All @@ -35,26 +33,6 @@ protected function registerEncrypter()
});
}

/**
* Configure Opis Closure signing for security.
*
* @return void
*
* @deprecated Will be removed in a future Laravel version.
*/
protected function registerOpisSecurityKey()
{
if (\PHP_VERSION_ID < 80100) {
$config = $this->app->make('config')->get('app');

if (! class_exists(OpisSerializableClosure::class) || empty($config['key'])) {
return;
}

OpisSerializableClosure::setSecretKey($this->parseKey($config));
}
}

/**
* Configure Serializable Closure signing for security.
*
Expand Down
6 changes: 3 additions & 3 deletions src/Illuminate/Events/QueuedClosure.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
namespace Illuminate\Events;

use Closure;
use Illuminate\Queue\SerializableClosureFactory;
use Laravel\SerializableClosure\SerializableClosure;

class QueuedClosure
{
Expand Down Expand Up @@ -114,10 +114,10 @@ public function resolve()
{
return function (...$arguments) {
dispatch(new CallQueuedListener(InvokeQueuedClosure::class, 'handle', [
'closure' => SerializableClosureFactory::make($this->closure),
'closure' => new SerializableClosure($this->closure),
'arguments' => $arguments,
'catch' => collect($this->catchCallbacks)->map(function ($callback) {
return SerializableClosureFactory::make($callback);
return new SerializableClosure($callback);
})->all(),
]))->onConnection($this->connection)->onQueue($this->queue)->delay($this->delay);
};
Expand Down
4 changes: 2 additions & 2 deletions src/Illuminate/Foundation/Bus/PendingChain.php
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
use Closure;
use Illuminate\Contracts\Bus\Dispatcher;
use Illuminate\Queue\CallQueuedClosure;
use Illuminate\Queue\SerializableClosureFactory;
use Laravel\SerializableClosure\SerializableClosure;

class PendingChain
{
Expand Down Expand Up @@ -112,7 +112,7 @@ public function delay($delay)
public function catch($callback)
{
$this->catchCallbacks[] = $callback instanceof Closure
? SerializableClosureFactory::make($callback)
? new SerializableClosure($callback)
: $callback;

return $this;
Expand Down
5 changes: 3 additions & 2 deletions src/Illuminate/Queue/CallQueuedClosure.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
use Illuminate\Contracts\Container\Container;
use Illuminate\Contracts\Queue\ShouldQueue;
use Illuminate\Foundation\Bus\Dispatchable;
use Laravel\SerializableClosure\SerializableClosure;
use ReflectionFunction;

class CallQueuedClosure implements ShouldQueue
Expand Down Expand Up @@ -54,7 +55,7 @@ public function __construct($closure)
*/
public static function create(Closure $job)
{
return new self(SerializableClosureFactory::make($job));
return new self(new SerializableClosure($job));
}

/**
Expand All @@ -77,7 +78,7 @@ public function handle(Container $container)
public function onFailure($callback)
{
$this->failureCallbacks[] = $callback instanceof Closure
? SerializableClosureFactory::make($callback)
? new SerializableClosure($callback)
: $callback;

return $this;
Expand Down
43 changes: 0 additions & 43 deletions src/Illuminate/Queue/SerializableClosure.php

This file was deleted.

25 changes: 0 additions & 25 deletions src/Illuminate/Queue/SerializableClosureFactory.php

This file was deleted.

1 change: 0 additions & 1 deletion src/Illuminate/Queue/composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
"illuminate/pipeline": "^9.0",
"illuminate/support": "^9.0",
"laravel/serializable-closure": "^1.0",
"opis/closure": "^3.6",
"ramsey/uuid": "^4.2.2",
"symfony/process": "^6.0"
},
Expand Down
12 changes: 4 additions & 8 deletions src/Illuminate/Routing/Route.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
use Illuminate\Support\Traits\Macroable;
use Laravel\SerializableClosure\SerializableClosure;
use LogicException;
use Opis\Closure\SerializableClosure as OpisSerializableClosure;
use ReflectionFunction;
use Symfony\Component\Routing\Route as SymfonyRoute;

Expand Down Expand Up @@ -977,7 +976,6 @@ public function getMissing()

return is_string($missing) &&
Str::startsWith($missing, [
'C:32:"Opis\\Closure\\SerializableClosure',
'O:47:"Laravel\\SerializableClosure\\SerializableClosure',
]) ? unserialize($missing) : $missing;
}
Expand Down Expand Up @@ -1228,16 +1226,14 @@ public function setContainer(Container $container)
public function prepareForSerialization()
{
if ($this->action['uses'] instanceof Closure) {
$this->action['uses'] = serialize(\PHP_VERSION_ID < 70400
? new OpisSerializableClosure($this->action['uses'])
: new SerializableClosure($this->action['uses'])
$this->action['uses'] = serialize(
new SerializableClosure($this->action['uses'])
);
}

if (isset($this->action['missing']) && $this->action['missing'] instanceof Closure) {
$this->action['missing'] = serialize(\PHP_VERSION_ID < 70400
? new OpisSerializableClosure($this->action['missing'])
: new SerializableClosure($this->action['missing'])
$this->action['missing'] = serialize(
new SerializableClosure($this->action['missing'])
);
}

Expand Down
1 change: 0 additions & 1 deletion src/Illuminate/Routing/RouteAction.php
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,6 @@ protected static function makeInvokable($action)
public static function containsSerializedClosure(array $action)
{
return is_string($action['uses']) && Str::startsWith($action['uses'], [
'C:32:"Opis\\Closure\\SerializableClosure',
'O:47:"Laravel\\SerializableClosure\\SerializableClosure',
]) !== false;
}
Expand Down
6 changes: 2 additions & 4 deletions tests/Routing/RouteActionTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
use Illuminate\Database\Eloquent\Model;
use Illuminate\Routing\RouteAction;
use Laravel\SerializableClosure\SerializableClosure;
use Opis\Closure\SerializableClosure as OpisSerializableClosure;
use PHPUnit\Framework\TestCase;

class RouteActionTest extends TestCase
Expand All @@ -16,9 +15,8 @@ public function test_it_can_detect_a_serialized_closure()
return $user;
};

$action = ['uses' => serialize(\PHP_VERSION_ID < 70400
? new OpisSerializableClosure($callable)
: new SerializableClosure($callable)
$action = ['uses' => serialize(
new SerializableClosure($callable)
)];

$this->assertTrue(RouteAction::containsSerializedClosure($action));
Expand Down
6 changes: 2 additions & 4 deletions tests/Routing/RouteSignatureParametersTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
use Illuminate\Database\Eloquent\Model;
use Illuminate\Routing\RouteSignatureParameters;
use Laravel\SerializableClosure\SerializableClosure;
use Opis\Closure\SerializableClosure as OpisSerializableClosure;
use PHPUnit\Framework\TestCase;
use ReflectionParameter;

Expand All @@ -17,9 +16,8 @@ public function test_it_can_extract_the_route_action_signature_parameters()
return $user;
};

$action = ['uses' => serialize(\PHP_VERSION_ID < 70400
? new OpisSerializableClosure($callable)
: new SerializableClosure($callable)
$action = ['uses' => serialize(
new SerializableClosure($callable)
)];

$parameters = RouteSignatureParameters::fromAction($action);
Expand Down