Skip to content

[8.x] Use type hints in cast.stub to match interface #38234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 4, 2021
Merged

[8.x] Use type hints in cast.stub to match interface #38234

merged 1 commit into from
Aug 4, 2021

Conversation

dbakan
Copy link
Contributor

@dbakan dbakan commented Aug 4, 2021

The CastsAttributes interface uses type hints for the params $key and $attributes.

This PR adds the same type hints to the cast.stub.

@dbakan dbakan changed the title Use type hints in cast.stub to match interface [8.x] Use type hints in cast.stub to match interface Aug 4, 2021
@taylorotwell taylorotwell merged commit f1427d1 into laravel:8.x Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbakan @taylorotwell