Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Mark MaintenanceModeException as deprecated #37497

Merged

Conversation

vigneshgurusamy
Copy link
Contributor

Ref: #35635

@driesvints
Copy link
Member

Please explain why this is needed and don't link to an issue, thanks.

@vigneshgurusamy
Copy link
Contributor Author

As I mentioned in the issue, Taylor has migrated the Maintenance mode exception from MaintenanceModeException to HttpException to enhance the feature and it was not updated in the documentation.

For two reasons I have created this PR:

  1. MaintenanceModeException is not used anywhere in the framework code.
  2. More than one person was affected by this change. So by deprecating the unused exception will help the people to identify the change without BC and IDE will highlight the deprecation if it is used in their code.

@taylorotwell taylorotwell merged commit f3493fc into laravel:8.x May 27, 2021
@vigneshgurusamy vigneshgurusamy deleted the maintenance-mode-exception branch May 27, 2021 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants