[8.x] Add dd() method to TestResponse class#36378
Closed
duncanmcclean wants to merge 1 commit intolaravel:8.xfrom
duncanmcclean:add-dd-method-to-http-testing-chain
Closed
[8.x] Add dd() method to TestResponse class#36378duncanmcclean wants to merge 1 commit intolaravel:8.xfrom duncanmcclean:add-dd-method-to-http-testing-chain
duncanmcclean wants to merge 1 commit intolaravel:8.xfrom
duncanmcclean:add-dd-method-to-http-testing-chain
Conversation
Collaborator
|
You should probably have this instead call the dump method. Also, I think this will make a mess for parallel testing... // cc @nunomaduro |
Contributor
A framework/src/Illuminate/Testing/TestResponse.php Lines 1077 to 1095 in fe72373 That method originally called dd() but it was changed to dump() to allow database teardown, PHPUnit script cleanup, etc. To short-circuit a test being dumped, maybe throwing a |
Member
|
I would just call dump() and run that single test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new
ddmethod to the fluentTestResponseclass.Example
Previously... you'd have to comment out any assertions at the end of your chain, assign it to a variable and finally actually
ddit.Now... with this PR, you'll be able to simply add the
->dd()method anywhere in your chain and the HTTP response will be die dumped.I've reviewed the
ddmethods available in other places in the codebase, like in theBuilderclass and theStringableclass and I couldn't find any tests that cover theddmethod so I was unsure on how to actually add tests for this addition. Please let me know if I've missed anything.