Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Fixes parallel testing when a database is configured using URLs #36204

Merged
merged 2 commits into from
Feb 9, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions src/Illuminate/Testing/Concerns/TestDatabases.php
Original file line number Diff line number Diff line change
Expand Up @@ -142,10 +142,19 @@ protected function switchToDatabase($database)

$default = config('database.default');

config()->set(
"database.connections.{$default}.database",
$database,
);
$url = config("database.connections.{$default}.url");

if ($url) {
config()->set(
"database.connections.{$default}.url",
preg_replace('/^(.*)(\/[\w-]*)(\??.*)$/', "$1/{$database}$3", $url),
);
} else {
config()->set(
"database.connections.{$default}.database",
$database,
);
}
}

/**
Expand Down
108 changes: 108 additions & 0 deletions tests/Testing/Concerns/TestDatabasesTest.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,108 @@
<?php

namespace Illuminate\Tests\Testing\Concerns;

use Illuminate\Container\Container;
use Illuminate\Support\Facades\DB;
use Illuminate\Testing\Concerns\TestDatabases;
use Mockery as m;
use PHPUnit\Framework\TestCase;
use ReflectionMethod;

class TestDatabasesTest extends TestCase
{
protected function setUp(): void
{
parent::setUp();

Container::setInstance($container = new Container);

$container->singleton('config', function () {
return m::mock(Config::class)
->shouldReceive('get')
->once()
->with('database.default', null)
->andReturn('mysql')
->getMock();
});

$_SERVER['LARAVEL_PARALLEL_TESTING'] = 1;
}

public function testSwitchToDatabaseWithoutUrl()
{
DB::shouldReceive('purge')->once();

config()->shouldReceive('get')
->once()
->with('database.connections.mysql.url', false)
->andReturn(false);

config()->shouldReceive('set')
->once()
->with('database.connections.mysql.database', 'my_database_test_1');

$this->switchToDatabase('my_database_test_1');
}

/**
* @dataProvider databaseUrls
*/
public function testSwitchToDatabaseWithUrl($testDatabase, $url, $testUrl)
{
DB::shouldReceive('purge')->once();

config()->shouldReceive('get')
->once()
->with('database.connections.mysql.url', false)
->andReturn($url);

config()->shouldReceive('set')
->once()
->with('database.connections.mysql.url', $testUrl);

$this->switchToDatabase($testDatabase);
}

public function switchToDatabase($database)
{
$instance = new class {
use TestDatabases;
};

$method = new ReflectionMethod($instance, 'switchToDatabase');
tap($method)->setAccessible(true)->invoke($instance, $database);
}

public function databaseUrls()
{
return [
[
'my_database_test_1',
'mysql://root:@127.0.0.1/my_database?charset=utf8mb4',
'mysql://root:@127.0.0.1/my_database_test_1?charset=utf8mb4',
],
[
'my_database_test_1',
'mysql://my-user:@localhost/my_database',
'mysql://my-user:@localhost/my_database_test_1',
],
[
'my-database_test_1',
'postgresql://my_database_user:@127.0.0.1/my-database?charset=utf8',
'postgresql://my_database_user:@127.0.0.1/my-database_test_1?charset=utf8',
],
];
}

public function tearDown(): void
{
parent::tearDown();

Container::setInstance(null);

unset($_SERVER['LARAVEL_PARALLEL_TESTING']);

m::close();
}
}
2 changes: 1 addition & 1 deletion tests/Testing/ParallelConsoleOutputTest.php
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php

namespace Illuminate\Tests\Foundation;
namespace Illuminate\Tests\Testing;

use Illuminate\Testing\ParallelConsoleOutput;
use PHPUnit\Framework\TestCase;
Expand Down
2 changes: 1 addition & 1 deletion tests/Testing/ParallelTestingTest.php
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php

namespace Illuminate\Tests\Foundation;
namespace Illuminate\Tests\Testing;

use Illuminate\Container\Container;
use Illuminate\Testing\ParallelTesting;
Expand Down
2 changes: 1 addition & 1 deletion tests/Testing/TestResponseTest.php
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php

namespace Illuminate\Tests\Foundation;
namespace Illuminate\Tests\Testing;

use Illuminate\Container\Container;
use Illuminate\Contracts\View\View;
Expand Down