Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Delay pushing jobs to queue until database transactions are committed #35422

Merged
merged 10 commits into from
Dec 9, 2020
Merged

[8.x] Delay pushing jobs to queue until database transactions are committed #35422

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4ce7b2e
allow marking jobs to be dispatched after db transactions …
themsaid Nov 30, 2020
068ac2c
Merge branch '8.x' of https://github.com/laravel/framework into dispa…
themsaid Nov 30, 2020
4f94ff9
add tests
themsaid Nov 30, 2020
4f76ee5
include afterCommit and beforeCommit in PendingDispatch
themsaid Nov 30, 2020
56e1b24
fix style
themsaid Nov 30, 2020
2ba6890
fix style
themsaid Nov 30, 2020
399672c
fix tests
themsaid Nov 30, 2020
5a187d4
fix conflicts
themsaid Dec 9, 2020
5ef349b
fix tests
themsaid Dec 9, 2020
ed6bd2e
fix tests
themsaid Dec 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix tests
  • Loading branch information
@themsaid
themsaid committed Nov 30, 2020
commit 399672c2e42aee28b6524d1300339aadbce762a5
3 changes: 1 addition & 2 deletions tests/Integration/Queue/QueueConnectionTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

namespace Illuminate\Tests\Integration\Queue;

use Aws\Sqs\Exception\SqsException;
use Illuminate\Bus\Queueable;
use Illuminate\Contracts\Queue\ShouldQueue;
use Illuminate\Database\DatabaseTransactionsManager;
Expand Down Expand Up @@ -53,7 +52,7 @@ public function testJobWillGetDispatchedInsideATransactionWhenExplicitlyIndicate

try {
Bus::dispatch((new QueueConnectionTestJob)->beforeCommit());
} catch (SqsException $e) {
} catch (\Throwable $e) {
// This job was dispatched
}
}
Expand Down