[8.x] Fix Postgres Dump #35018
Merged
[8.x] Fix Postgres Dump #35018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe #34293 broke Postgres dumps by breaking how migration table data was appended to the dump file. The migration data was never appended to the file because the
appendMigrationDatamethod was no longer able to parse them out of the binary dump.This corrects this by using the connection to retrieve all table names then excluding table data for all tables EXCEPT the migrations table in the binary dump.
I have tested this locally on my machine with Postgres.