Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Fix issue where Storage::path breaks when using cache due to missing method in CachedAdapter #33602

Merged
merged 3 commits into from
Jul 21, 2020

Conversation

rezen
Copy link
Contributor

@rezen rezen commented Jul 20, 2020

PR title sums everything up simply.

@GrahamCampbell
Copy link
Member

I don't think this should be fixed here. The cached adapter needs to be updated?

@rezen
Copy link
Contributor Author

rezen commented Jul 20, 2020

@GrahamCampbell I had considered that, but decided against that for a couple reasons

  • The pattern if ($adapter instanceof CachedAdapter) { is already in place (used 3 times)
  • Implementing at the FilesystemAdapter is more stable than updating the dependency which may introduce other breakages.

@rezen
Copy link
Contributor Author

rezen commented Jul 20, 2020

I should additionally add, the Filesystem contract does not include path

@taylorotwell taylorotwell merged commit 77ffbea into laravel:7.x Jul 21, 2020
@GrahamCampbell GrahamCampbell changed the title #32917 Fix issue where Storage::path breaks when using cache due to missing method in CachedAdapter [7.x] Fix issue where Storage::path breaks when using cache due to missing method in CachedAdapter Jul 21, 2020
@rezen rezen deleted the patch-1 branch July 22, 2020 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants