[7.x] set/reset the select to from.* in cloneForPaginationCount #32691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickomeara
changed the title
* wrapping a join with the same table column name produces a duplicate column error
patrickomeara
changed the title
|
This doesn't feel correct. This is mutating the original query instead of the cloned query. |
|
Paste the exact Eloquent query from your actual code base showing how to trigger this. |
|
Fixed this here: 98a242e |
PauBenetPrat
pushed a commit
to PauBenetPrat/framework
that referenced
this pull request
Mar 11, 2021
…gination. This was added on this PR laravel#32691 at this specific commit: laravel@98a242e A part from that, there is no way to select null columns, always receiving array(null) instead. On the other hand, if we join tables and use select *, we could be using diferent fields from each table but it always breaks when paginating because of duplicate column name 'id'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #32624 the pagination count query is now wrapped in a
select count(*) as aggregatequery for group by and havings, and the builder is used as a subquery.If the builder has a join, but doesn't have a select, a duplicate column error is produced.
#32624 (comment)
This PR ensures the select is only from the primary table. As it is a subquery for a count, the columns in the subquery are irrelevant.