[7.x] Update runPaginationCountQuery to support groupBy and sub-selects #32688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamCampbell
changed the title
bennothommo
added a commit
to wintercms/storm
that referenced
this pull request
Jun 17, 2021
Refs: laravel/framework#32688 Co-authored-by: Marc Jauvin <marc.jauvin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR patches a change in
7.10.0that updated pagination count for group by queries. This change broke functionality when a grouped query was also using sub-selects.The changes here update the method to use an ad hoc aggregate rather than the existing
countmethod, which strips the necessaryselectandcolumnsbindings.