-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[6.x] Only restore common relations #32613
Conversation
There is an error with |
@oleksiyPetlyuk this should be fixed in the latest release. |
What exactly is getQueueableRelations returning for you? |
We are also seeing For us, $relations = $this->map->getQueueableRelations()->all();
dump($relations);
Hope that helps |
OK Thanks that is helpful. Fixing now. |
Im using Laravel 6.18.12 |
Fixed on 6.18.13. |
Fixed on 7.10.1. |
Installed and fix confirmed in |
Fixes #26126
We only want to restore relationships that are common amongst all models in the collection. Otherwise there will be errors be attempting to restore the collection.
One downside to this PR could be potential performance implications of getting the queueable relationships for each model in the collection. I did this in a collection of about 1000 models and it took 0.70ms on my local machine.