[7.x] Allow disabling of global middleware #32404
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix issue #32384, and is supplementary to PR #32347 by @dsazup , after discussion with @driesvints.
At time of writing global middleware doesn't support access to routes, because the route matching process is done after the global middleware stack has run. As a result, accessing the current route on
Illuminate\Foundation\Http\Kernel
works for terminable (global) middleware, but not for regular middleware.I've moved the global middleware stack check to its own method, and manually match there now, but obviously there's a performance consideration there. The obvious solution is marking the
findRoute
method ofIlluminate\Routing\Router
as public and caching the actual lookup, but that'd be a breaking change in the contract. I'm open for thoughts on this.