Exclude excluded middleware from global stack #32402
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please base your PR off of the 7.x branch. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix issue #32384, and is supplementary to PR #32347 by @dsazup , after discussion with @driesvints . I should've marked it as draft for reasons outlined below, but Github won't let me to that after the fact.
At time of writing global middleware doesn't support access to route names, because the route matching process is done after the global middleware stack has run. As a result, accessing the current route on
Illuminate\Foundation\Http\Kernelworks for terminable (global) middleware, but not for regular middleware.I've moved the global middleware stack check to its own method, and manually match there now, but obviously there's a performance consideration there. The obvious solution is marking the
findRoutemethod ofIlluminate\Routing\Routeras public and caching the actual lookup, but that'd be a breaking change in the contract. I'm open for thoughts on this.