[6.x] Use BindingResolutionException to signal problem with container resolution #32349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ution As part of static analysis sometimes abstracts get resolved which aren't resolvable => that's totally fine but it would help to use a common exception to signal this. I figured BindingResolutionException would be the correct one. For example, it's caught in cases like `\Illuminate\Foundation\Exceptions\Handler::whoopsHandler` and IMHO this would also benefit from a streamlined exception.
|
Could you please send the same PR to Lumen 7 please (not Lumen 6 since LTS only applied to laravel/framework). |
Aye, see laravel/lumen-framework#1065 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #32348 but targeting L6
As part of static analysis sometimes abstracts get resolved which aren't
resolvable => that's totally fine but it would help to use a common
exception to signal this.
I figured BindingResolutionException would be the correct one. For example,
it's caught in cases like
\Illuminate\Foundation\Exceptions\Handler::whoopsHandlerand IMHO this would also benefit from a streamlined exception.