[7.x] Fix merging boolean or null attributes in Blade components #32245
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix to escape merged attributes with
e
creates an unexpected behaviour when merging attributes withnull
or boolean values, for example:Will print
required="" readonly="" disabled="1"
instead ofdisabled="disabled"
This is also inconsistent with the result that we'd get if we create a new instance of
ComponentAttributeBag
passing the same array as the first argument of the constructor:Will print
disabled="disabled"
and I think this is the right result.Therefore I'm submitting this PR to avoid escaping boolean or
null
values so we get the same result in both cases.