Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.x] Fix a bug with slash prefix #31760

Merged
merged 1 commit into from
Mar 5, 2020
Merged

[7.x] Fix a bug with slash prefix #31760

merged 1 commit into from
Mar 5, 2020

Conversation

driesvints
Copy link
Member

@driesvints driesvints commented Mar 5, 2020 •
edited
Loading

Fixes an issue where the prefix could be a slash. Can maybe use some polishing.

Route::prefix('/')->group(function ($router) {
    $router->view('welcome/user', 'welcome');
});

Fixes #31759

@driesvints driesvints mentioned this pull request Mar 5, 2020
Closed
@crynobone
Copy link
Member

@driesvints tested locally 👍

@driesvints driesvints force-pushed the fix-bug-with-slash-prefix branch from 25d50ed to c087ffe Compare March 5, 2020 13:55
@taylorotwell taylorotwell merged commit b3adb67 into 7.x Mar 5, 2020
@GrahamCampbell GrahamCampbell deleted the fix-bug-with-slash-prefix branch March 5, 2020 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crynobone crynobone crynobone left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Route prefix get truncated when using ->prefix('/') fluent routing registration
3 participants
@driesvints @crynobone @taylorotwell