[6.x] Adds missing options for PhpRedis #31021
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amranidev
approved these changes
Jan 3, 2020
|
Thanks. Could you add some tests too please? |
|
Tests are failing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for options on PhpRedis connections that were not allowed before. This includes specifying a
serializer,scanoption, andfailoverbehavior for cluster connections.The
serializeroption allows for usingigbinarywhich can use significantly less storage space as documented here.The
scanoption allows for customizing the behavior of scan commands as described here.The
failoveroption allows for customizing the behavior of a cluster connection as described here.