[6.x] Search for Similar Results #30886
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
first we take the first key/value pair of the expected data, and look to see if that exists in the database. If that finds results, we'll send those back to the developer since they're easier to compare. if we don't find any of those results, we'll fallback to the old way of just returning results from the table.
|
ok, clearly I did not run my tests before submitting this PR... I didn't realize the output of this assertion was so well tested. I'll update tests, and re-push. I don't see I way to switch the status, but consider this PR draft for now. |
|
@browner12 just feel free to resubmit once you're ready. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
assertDatabaseHas()assertion, the failure method returns the first couple results out of the database. This is not incredibly useful since those results are not guaranteed to contain the row of our expected data.This PR allow the failure message to make an educated guess on the DB row we are most likely trying to compare to. It gives priority to the first key/value pair in our expected data, and performs a query based solely on that 1 piece of information. If it finds rows matching this data, it will return them. If it doesn't find any results from its educated guess, it will fallback to the current method of returning results.