Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Revert adding head method to router #30710

Merged
merged 1 commit into from
Nov 29, 2019
Merged

[6.x] Revert adding head method to router #30710

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Revert adding head method to router 
This reverts #30646 because it's incomplete and currently breaks the route:list command.

Closes #30708
  • Loading branch information
@driesvints
driesvints committed Nov 28, 2019
commit 303602dcd2fdf2ee8af85daf4336b1f550342769
12 changes: 0 additions & 12 deletions src/Illuminate/Routing/Router.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,18 +132,6 @@ public function __construct(Dispatcher $events, Container $container = null)
$this->container = $container ?: new Container;
}

/**
* Register a new HEAD route with the router.
*
* @param string $uri
* @param \Closure|array|string|callable|null $action
* @return \Illuminate\Routing\Route
*/
public function head($uri, $action = null)
{
return $this->addRoute('HEAD', $uri, $action);
}

/**
* Register a new GET route with the router.
*
Expand Down
1 change: 0 additions & 1 deletion src/Illuminate/Support/Facades/Route.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
/**
* @method static \Illuminate\Routing\Route fallback(\Closure|array|string|callable|null $action = null)
* @method static \Illuminate\Routing\Route get(string $uri, \Closure|array|string|callable|null $action = null)
* @method static \Illuminate\Routing\Route head(string $uri, \Closure|array|string|callable|null $action = null)
* @method static \Illuminate\Routing\Route post(string $uri, \Closure|array|string|callable|null $action = null)
* @method static \Illuminate\Routing\Route put(string $uri, \Closure|array|string|callable|null $action = null)
* @method static \Illuminate\Routing\Route delete(string $uri, \Closure|array|string|callable|null $action = null)
Expand Down