[6.x] Allow using the signed route middleware with relative signed URLs #30336
Conversation
| * @return \Illuminate\Http\Response | ||
| * | ||
| * @throws \Illuminate\Routing\Exceptions\InvalidSignatureException | ||
| */ | ||
| public function handle($request, Closure $next) | ||
| public function handle($request, Closure $next, $relative = null) |
There was a problem hiding this comment.
This breaks compatibility with L6. It would be better to use $relative = func_get_arg(3); if the middleware handling supports it.
There was a problem hiding this comment.
Heya. This would indeed need to go to master because it breaks the message signature.
There was a problem hiding this comment.
so I should change the base to master and aim for L7?
There was a problem hiding this comment.
Either that or make it compatible with L6, as I'm pretty sure @driesvints meant the method sinature.
Have a look at accessing function parameters without changing signature.
If you chose the latter don't forget to send another pr to change the signature when this was merged.
driesvints
changed the title
|
I am closing this pull request because it lacks sufficient explanation, tests, or both. It is difficult for us to merge pull requests without these things because the change may introduce breaking changes to the framework. Feel free to re-submit your change with a thorough explanation of the feature and tests - integration tests are preferred over unit tests. Please include it's benefit to end users; the reasons it does not break any existing features; how it makes building web applications easier, etc. Thanks! |
Changed
ValidateSignaturemiddleware