Skip to content

[5.8] Simplify isset() #29581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 15, 2019
Merged

[5.8] Simplify isset() #29581

merged 2 commits into from
Aug 15, 2019

Conversation

fitv
Copy link
Contributor

@fitv fitv commented Aug 15, 2019

Simplify isset().

antonkomarev
antonkomarev reviewed Aug 15, 2019
View reviewed changes
src/Illuminate/Database/Connectors/SqlServerConnector.php Outdated
return $config['host'];
} else {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

else statement could be removed because of early return:

if (empty($config['port'])) {
    return $config['host'];
}

return $config['host'].$separator.$config['port'];

@taylorotwell taylorotwell merged commit 51a0ad1 into laravel:5.8 Aug 15, 2019
@fitv fitv deleted the simplify-isset branch August 16, 2019 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@antonkomarev antonkomarev antonkomarev left review comments

@seriquynh seriquynh seriquynh approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fitv @antonkomarev @seriquynh @taylorotwell