Skip to content

[5.8] Fix orWhereDay(), orWhereMonth() and orWhereYear() #29317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2019
Merged

[5.8] Fix orWhereDay(), orWhereMonth() and orWhereYear() #29317

merged 1 commit into from
Jul 29, 2019

Conversation

staudenmeir
Copy link
Contributor

orWhereDay(), orWhereMonth() and orWhereYear() call addDateBasedWhere() instead of their "base" methods. As a result, they don't support DateTime objects (#25315) or integer values (#28185).

@taylorotwell taylorotwell merged commit 75a1f4e into laravel:5.8 Jul 29, 2019
@staudenmeir staudenmeir deleted the or-where branch July 29, 2019 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@seriquynh seriquynh seriquynh approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@staudenmeir @seriquynh @taylorotwell