Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.8] Let mix helper use assets url #28905

Merged
merged 2 commits into from
Jun 20, 2019
Merged

Conversation

themsaid
Copy link
Member

No description provided.

@taylorotwell taylorotwell merged commit 03e82c9 into laravel:5.8 Jun 20, 2019
@GrahamCampbell
Copy link
Member

Is this not a breaking change?

@GrahamCampbell GrahamCampbell changed the title Let mix helper use assets url [5.8] Let mix helper use assets url Jun 21, 2019
@timrspratt
Copy link
Contributor

For HTML <script> and <link>, I currently use asset(mix(...)), which detects a valid URL and so all is fine. But I also have use cases for mix() with Spaties SSR package. This creates a local file path and so results in the error:

Server script at path `/var/www/current/public/https://XXXXX.cloudfront.net/js/entry-server.js` doesn't exist"

Is this likely to be reverted, or should I account for it / submit a PR to Spaties package to remove the host from the string?

Thanks

@GrahamCampbell
Copy link
Member

I will have the exact same error if I upgrade to the latest patch release, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants