Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.8] Add support for containsAll in Str:contains #28688

Closed
wants to merge 3 commits into from
Closed

[5.8] Add support for containsAll in Str:contains #28688

wants to merge 3 commits into from

Conversation

chrisbbreuer
Copy link
Contributor

Hi everyone,

Every now and then I run into a dilemma where I want to check if an array of values is contained within a string.

This adds the functionality to check for all array values inside a string.

Check out the tests to see all the supported scenarios.

I hope you guys find this useful, too 🙂

Hi everyone,

Every now and then I run into a dilemma where I want to check if an array of values is contained within a string.

This adds the functionality to check for all array values inside a string.

Check out the tests to see all the supported scenarios.

I hope you guys find this useful, too 🙂
@driesvints
Copy link
Member

Hey @chris1904, thanks. Because of the extra $containsAll = false to the method signature this is unfortunately a breaking change. I think it's best that this might be a new function or otherwise this needs to be sent to the master branch. Feel free to send in a new PR with whatever you decide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants