[5.7] Lenient log stacks - #27308
Merged
Merged
Conversation
Member
|
Lol... that's a great class name from Monolog :) |
Member
|
Renamed option to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A simple yet powerful addition to the
stacklog driver: whenever a log stack is marked aslenient, the stack gets wrapped in theWhatFailureGroupHandler. Taken from Monolog's documentation:So in this case log handlers throwing exceptions themselves are gracefully ignored, allowing the stack to continue. Highly useful to prevent white screens in production when for instance Slack cannot be reached.
I had a hard time choosing the right keyword (lenient, tolerant, continue, ignore_exceptions, ...), so please adjust as desired.
Disclaimer: I know this can be accomplished by tapping into the Monolog instance (
tap) and rebinding the handler, but since it is such a useful thing I figured suggesting it as a config would be appropriate and helpful to many that are unaware of the possibility.