[5.8] Remove prefix setting for Amazon SQS, add url #27086
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using Amazon SQS as the queue backend, it's not convenient to have the queue name automatically appended to the Amazon SQS endpoint URL. This is because the Amazon SQS URL may need to be different depending on environment, whilst the queue name should remain the same, given code
Job::dispatch()->onQueue('emails')
andqueue:work --queue=emails
commands will specify it.This PR removes the use of the SQS specific setting
prefix
and relies on a new SQS specific settingurl
. This means it can change independently of the queue name.This is a obviously, a breaking change so it would have to be in a major version release if it was accepted.
A PR over on the laravel/laravel repository to update config/queue.php has also been submitted.