-
Notifications
You must be signed in to change notification settings - Fork 11.4k
[5.8] Fix for container app()->call() method #26920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[5.8] Deprecate useless Arr and Str global helper methods/aliases (#2…
There are a bunch of changes in this PR that are not related to your change. For example, there are styling changes, the adding of function return types to functions you have not changed etc (I dont think we use those in the framework either, but I could be wrong). To increase the changes of your PR been accepted by Taylor the PR should only contain changes directly related to what you are changing. Otherwise it makes the PR very big and difficult to see what actual code changes are been done. |
Some changes are accidentally made by IDE. Anyway this is a work in progress and still requires a lot more consideration. |
Thanks for the PR, I like it 👍 |
2f37e4f
to
2982e17
Compare
@imanghafoori1 sorry, the Github GUI showed me some rebase notices but those turned out to be unrelated of conflicts. |
It seems the ContainerTest.php file needs to be split apart into more files, each covering one specific feature. I do not know whether it is against any convention or not. |
5d1fcdf
to
35cb58f
Compare
aed31eb
to
4a4c3be
Compare
2fe2aad
to
895e5f2
Compare
7b9a174
to
2c3e8e0
Compare
401f264
to
0aa28b8
Compare
0aa28b8
to
6d23cae
Compare
No plans to merge this implementation. |
Ok, hope I have manged to provide something that can be inspired from in future. |
@taylorotwell This means that the end user can enjoy the automatic method injection when using real-time facades. |
Addresses these issues :
#26851
#22687
#26837
Following my previous bug fix #26852 which caused a new nasty bug and eventually got reverted...
I created an other PR to add the missing tests to cover more cases #26897
Now I am coming up with an other solution for making it really fixed.