Skip to content

[5.8] Fix for container app()->call() method #26920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 24 commits into from

Conversation

imanghafoori1
Copy link
Contributor

@imanghafoori1 imanghafoori1 commented Dec 19, 2018

Addresses these issues :
#26851
#22687
#26837

Following my previous bug fix #26852 which caused a new nasty bug and eventually got reverted...
I created an other PR to add the missing tests to cover more cases #26897

Now I am coming up with an other solution for making it really fixed.

@laurencei
Copy link
Contributor

There are a bunch of changes in this PR that are not related to your change.

For example, there are styling changes, the adding of function return types to functions you have not changed etc (I dont think we use those in the framework either, but I could be wrong).

To increase the changes of your PR been accepted by Taylor the PR should only contain changes directly related to what you are changing. Otherwise it makes the PR very big and difficult to see what actual code changes are been done.

@imanghafoori1
Copy link
Contributor Author

Some changes are accidentally made by IDE.
But this fix required a lot of change in the logic.
I try to provide enough comments, meaningful variable names and unit test to be clear.

Anyway this is a work in progress and still requires a lot more consideration.

@mfn
Copy link
Contributor

mfn commented Dec 20, 2018

Thanks for the PR, I like it 👍

@imanghafoori1 imanghafoori1 force-pushed the master branch 2 times, most recently from 2f37e4f to 2982e17 Compare December 21, 2018 13:33
@driesvints
Copy link
Member

@imanghafoori1 sorry, the Github GUI showed me some rebase notices but those turned out to be unrelated of conflicts.

@imanghafoori1 imanghafoori1 changed the title [5.8] Fix for container call() method [5.8] Fix for container app()->call() method Dec 21, 2018
@imanghafoori1
Copy link
Contributor Author

It seems the ContainerTest.php file needs to be split apart into more files, each covering one specific feature. I do not know whether it is against any convention or not.
(For Example all the tests covering the app()->call() should reside in one file.)

rename a variable
reactors
@imanghafoori1 imanghafoori1 force-pushed the master branch 3 times, most recently from aed31eb to 4a4c3be Compare December 25, 2018 18:22
@imanghafoori1 imanghafoori1 force-pushed the master branch 2 times, most recently from 2fe2aad to 895e5f2 Compare December 25, 2018 19:07
@imanghafoori1 imanghafoori1 force-pushed the master branch 2 times, most recently from 7b9a174 to 2c3e8e0 Compare December 25, 2018 20:01
@imanghafoori1 imanghafoori1 force-pushed the master branch 3 times, most recently from 401f264 to 0aa28b8 Compare December 25, 2018 20:38
@taylorotwell
Copy link
Member

No plans to merge this implementation.

@imanghafoori1 imanghafoori1 deleted the master branch December 26, 2018 14:34
@imanghafoori1
Copy link
Contributor Author

Ok, hope I have manged to provide something that can be inspired from in future.

@imanghafoori1 imanghafoori1 restored the master branch December 31, 2018 14:39
@imanghafoori1
Copy link
Contributor Author

@taylorotwell
I see that if this issue gets fixed, then laravel can use $app->call(... in the base facade class to call the underlying implementation of facades.

This means that the end user can enjoy the automatic method injection when using real-time facades.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants