[5.7] [WIP] bug fix for app()->call() #26915
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rt for sequential array method call.
|
You have a better chance by targeting the master branch and fixing the issue for the next release. It gives more time for thorough test. |
|
Absolutely no way this gets merged on 5.7. |
|
@taylorotwell |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some changes in the BoundMethod class to make a fix addressing these issues:
#26851
#22687
#26837
Following the my previous bug fix #26852 which caused a new nasty bug and eventually got reverted...
I created an other PR to add the missing tests to cover more cases #26897
After one sleepless night I am coming up with an other fundamental solution for making it really fixed.
I know I am asked not to make a PR again for that feature but please let me try again.
This time much more vigilant, with more tests.
I will add more tests tomorrow to be really sure that no more revert will happen