[5.8] Remove the container makeWith method

src/Illuminate/Container/Container.php

@@ -584,18 +584,6 @@ public function factory($abstract)
         };
     }
 
-    /**
-     * An alias function name for make().
-     *
-     * @param  string  $abstract
-     * @param  array  $parameters
-     * @return mixed
-     */
-    public function makeWith($abstract, array $parameters = [])
-    {
-        return $this->make($abstract, $parameters);
-    }
-
     /**
      * Resolve the given type from the container.
      *

src/Illuminate/Database/Concerns/BuildsQueries.php

@@ -138,7 +138,7 @@ public function unless($value, $callback, $default = null)
      */
     protected function paginator($items, $total, $perPage, $currentPage, $options)
     {
-        return Container::getInstance()->makeWith(LengthAwarePaginator::class, compact(
+        return Container::getInstance()->make(LengthAwarePaginator::class, compact(
             'items', 'total', 'perPage', 'currentPage', 'options'
         ));
     }
@@ -154,7 +154,7 @@ protected function paginator($items, $total, $perPage, $currentPage, $options)
      */
     protected function simplePaginator($items, $perPage, $currentPage, $options)
     {
-        return Container::getInstance()->makeWith(Paginator::class, compact(
+        return Container::getInstance()->make(Paginator::class, compact(
             'items', 'perPage', 'currentPage', 'options'
         ));
     }

tests/Container/ContainerTest.php

@@ -951,22 +951,6 @@ public function testResolvingCallbacksShouldBeFiredWhenCalledWithAliases()
         $this->assertEquals('taylor', $instance->name);
     }
 
-    public function testMakeWithMethodIsAnAliasForMakeMethod()
-    {
-        $mock = $this->getMockBuilder(Container::class)
-                     ->setMethods(['make'])
-                     ->getMock();
-
-        $mock->expects($this->once())
-             ->method('make')
-             ->with(ContainerDefaultValueStub::class, ['default' => 'laurence'])
-             ->will($this->returnValue(new stdClass));
-
-        $result = $mock->makeWith(ContainerDefaultValueStub::class, ['default' => 'laurence']);
-
-        $this->assertInstanceOf(stdClass::class, $result);
-    }
-
     public function testResolvingWithArrayOfParameters()
     {
         $container = new Container;