Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.7] Improve JSON UPDATE queries on MySQL #25794

Merged
merged 4 commits into from
Sep 27, 2018
Merged

[5.7] Improve JSON UPDATE queries on MySQL #25794

merged 4 commits into from
Sep 27, 2018

Conversation

staudenmeir
Copy link
Contributor

  • Simplifies compileJsonUpdateColumn() by using wrapJsonFieldAndPath().
  • [5.2] Added correct MySQL JSON bool handling and updating grammar #13242 fixed boolean values by placing them in the query as raw expressions: json_set(`options`, '$."enable"', false). The PR used the same technique for integer and doubles values, which is actually not necessary. I think we should use bindings as much as possible.
  • Adds support for null values.
  • Adds support for raw expressions.

@taylorotwell taylorotwell merged commit d5e035c into laravel:5.7 Sep 27, 2018
@staudenmeir staudenmeir deleted the json-update-mysql branch September 27, 2018 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@staudenmeir @taylorotwell