[5.7] Throw on trying to drop foreign keys in SQLite #24052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamCampbell
changed the title
GrahamCampbell
changed the title
GrahamCampbell
requested changes
Apr 29, 2018
| ); | ||
| } | ||
|
|
||
| if ($this->commandsNamed(['dropForeign'])->count() > 1) { |
|
Yes, sorry. In my test sample, I had several |
|
Excuse me for my curiosity, but ... Why not just fix the implementation, instead of throwing the exception? As mentioned by @staudenmeir There is a proper way to drop foreign key in SQLite by recreating the table: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SQLite doesn't support dropping foreign keys (you would need to re-create the table).
See #24041