Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.6] Use the session() method of TestResponse #23974

Merged
merged 1 commit into from
Apr 25, 2018
Merged

[5.6] Use the session() method of TestResponse #23974

merged 1 commit into from
Apr 25, 2018

Conversation

shadoWalker89
Copy link
Contributor

No description provided.

carusogabriel
carusogabriel reviewed Apr 25, 2018
View reviewed changes
Copy link
Contributor

@carusogabriel carusogabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any specific reason why?

@shadoWalker89
Copy link
Contributor Author

shadoWalker89 commented Apr 25, 2018 •
edited
Loading

@carusogabriel Because the method already exists in the trait and it is intended for getting the session.
Btw, It is already used in once place.

Edit: this is where it is used before my PR

framework/src/Illuminate/Foundation/Testing/TestResponse.php

Line 710 in 0c6f474

$this->session()->has($key),

@taylorotwell taylorotwell merged commit e31e141 into laravel:5.6 Apr 25, 2018
@shadoWalker89 shadoWalker89 deleted the patch-1 branch April 25, 2018 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carusogabriel carusogabriel carusogabriel left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shadoWalker89 @carusogabriel @taylorotwell