Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.5] Fix for recent Carbon update (1.24.0) #23459

Merged
merged 1 commit into from
Mar 9, 2018
Merged

[5.5] Fix for recent Carbon update (1.24.0) #23459

merged 1 commit into from
Mar 9, 2018

Conversation

RyanThompson
Copy link
Contributor

@RyanThompson
Copy link
Contributor Author

Ayaya.. they just reverted their CS change: briannesbitt/Carbon@ef12cbd

image

@kylekatarnls
Copy link
Contributor

Please report us the bug on Carbon before such work-around.

@deleugpn
Copy link
Contributor

deleugpn commented Mar 9, 2018

@kylekatarnls according to the OP link, it was reported, but you replied saying it was Laravel's job to abide by Carbon's breaking change on a minor release.

@kylekatarnls
Copy link
Contributor

No, I did not say it was the Laravel's job, I meant Laravel no longer needs __set_state override at all.

But I missed this change, and it's a breaking change, I should not have put it in the release and as Laravel is not the only library that extends Carbon, revert the change was the right thing to do by our side.

I hope you understand my position.

@GrahamCampbell GrahamCampbell changed the title Fix for recent Carbon update (1.24.0) [5.5] Fix for recent Carbon update (1.24.0) Mar 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants