[5.5] Add option to disable wrapping Migration in transaction #22757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobvH
force-pushed
the
fix-migration-transactions-cannot-be-disabled
branch
from
cdabc49 to
bdc0978
Compare
GrahamCampbell
changed the title
This was referenced Jan 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides the option to disable transactionally wrapping a migration.
In #15780 we added the ability to wrap migrations in transactions, where supported. This is awesome!
However, for exactly the same reasons expressed here: rails/rails#9483
I propose the identical solution merged here: rails/rails#9507
TL;DR
Postgres and SQL Server usually do support transactional DDL, but both also have cases where they do not. Adding this simple, passive option gives us the power to handle this when needed.