[5.5] Fix custom URLs with prefix/root for AWS storage

[tillkruss]

This PR fixes a corner case of #22037 where the "path prefix" (or root) wasn't considered.

The "path prefix" is prepended to the path in all other cases, see path(), getAwsUrl() and getAwsTemporaryUrl().

Also, the temporary variable $config isn't necessary and was inlined.

[GrahamCampbell]

👍

[ntzm]

Might be worth adding a test to prevent regression?

[sisve]

This will be a breaking change for everyone using the new url feature. I'm one of those. Do we expect them all to read the issues/pr list daily to figure out the ongoing changes in the framework?

This should be a 5.6 change. And this should clearly show that we need a proper qa setup instead of the current way of accept-quickly-and-later-fix-it approach.

[tillkruss]

@sisve: I understand your concern. IMO this is a bug fix, because the root config parameter wasn't considered.

[paulofreitas]

If I'm not wrong this would only affect the existing code if you have added a root config option to your s3 disk config in config/filesystems.php - it's not there by default and it's not even documented, so it seems to me that it wouldn't be affecting everyone. 👍

[tillkruss]

Correct.

[sisve]

@paulofreitas It's not documented in the official docs, but it is not a secret. See it more as a problem on the qa department that we release new stuff but forget to update the documentation.

https://laravel-news.com/laravel-v5-5-21-released
https://medium.com/laravel-announcements/laravel-v5-5-21-released-aca3af740f79
https://twitter.com/LaravelLog/status/930500590400139266