[5.5] Added "software" as an uncountable word

[GrahamCampbell]

No description provided.

[BrandonShar]

This may be a nit-picky distinction, but should these be considered breaking changes? A few have been added lately, maybe it's time to think about a way to add these on a per-app basis?

[browner12]

does the break occur on things like guessing table names in models?

[BrandonShar]

Yes, it looks to me that it will. Model@getTable calls Str::plural which calls Pluralizer::plural.

[browner12]

i would agree then, yes technically these changes should go to master

[edmandiesamonte]

Assuming we have a model called Software, this is what we do since software's plural form is still software

class Software extends Model {
    
    protected $table = 'software';

With this new change, the code above would still work. Unless otherwise, softwares (with the 's') have already been used (i.e. in migrations), then it is really a breaking change.

Just my two cents.

Disclaimer: I authored a same PR for firmware #21306

[BrandonShar]

Sure, if you specify the table it's going to be fine, but I would guess most people don't do that. If you've been using a softwares table, it will break next time you update.

As a followup, the $uncountable array in Pluralizer is already public, so there's no code change needed to modify it in a service provider on a per app basis.