[5.4] Fix bug in compileInsert with empty values with SQLite.
#20424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taylorotwell
reviewed
Aug 4, 2017
| * @param string $sequence | ||
| * @return string | ||
| */ | ||
| public function compileInsertGetId(Builder $query, $values, $sequence) |
There was a problem hiding this comment.
Why did you override this method?
There was a problem hiding this comment.
My bad, no reason for that. It's removed.
tillkruss
changed the title
compileInsert with empty values with SQLite.compileInsert with empty values with SQLite.
mathieutu
force-pushed
the
fix/5.4/sqlite-grammar
branch
from
9bbd4d3
to
b664dd0
Compare
|
@themsaid can you test this? |
|
@taylorotwell Tested it and it seems to work. |
|
You're welcome... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
When you're trying to perform an insert with empty values with SQLite, a
QueryExceptionis thrown, with messageSQLSTATE[HY000]: General error: 1 near ")": syntax error (SQL: insert into "foos" () values ()).Indeed, the syntax for inserting an empty row is different between SQLite and MySQL.
You can reproduce that with
$model->create();(with$timestamps = falseof course to have a perfect empty model).With Mysql it works, with SQLite it fails.