Skip to content

[5.5] Allow easy ViewFactory override #20205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 21, 2017
Merged

[5.5] Allow easy ViewFactory override #20205

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f336c75
Allow easy ViewFactory override
deleugpn Jul 21, 2017
878fb0c
docblock
deleugpn Jul 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion src/Illuminate/View/ViewServiceProvider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ public function registerFactory()

$finder = $app['view.finder'];

$env = new Factory($resolver, $finder, $app['events']);
$env = $this->newFactory($resolver, $finder, $app['events']);

// We will also set the container instance on this view environment since the
// view composers may be classes registered in the container, which allows
Expand Down Expand Up @@ -133,4 +133,17 @@ public function registerBladeEngine($resolver)
return new CompilerEngine($this->app['blade.compiler']);
});
}

/**
* Create a new Factory Instance.
*
* @param \Illuminate\View\Engines\EngineResolver $resolver
* @param \Illuminate\View\ViewFinderInterface $finder
* @param \Illuminate\Contracts\Events\Dispatcher $events
* @return \Illuminate\View\Factory
*/
protected function newFactory($resolver, $finder, $events)
{
return new Factory($resolver, $finder, $events);
}
}