Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to get queue name from method #19703

Merged
merged 1 commit into from
Jun 21, 2017

Conversation

chrishardinge
Copy link
Contributor

When using Pusher, in order to specify which queue to use, public $broadcastQueue = 'name_of_queue' must be set.
Unfortunately, all public variables set in the event are sent onto Pusher - resulting in the end user receiving this, in addition to the intended payload.

Steps To Reproduce:

Create an event, specifying public $broadcastQueue, and run the worker.
Watch for the event in a web app, or simply use the "Debug Console" in Pusher to see the payload.

Usage

//  SendPushEvent.php
...
public function broadcastQueue()
{
    return 'name_of_queue';
}

I figure this would be consistent with broadcastOn and broadcastAs.

Does anyone have any thoughts on the matter?

@taylorotwell
Copy link
Member

This fix is fine. But we should also remove it from the Pusher payload to fix that bug. @themsaid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants