Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.4] Set data key when testing file uploads in nested array #18954

Merged
merged 3 commits into from
Apr 28, 2017
Merged

[5.4] Set data key when testing file uploads in nested array #18954

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7ac595c
Remove data key when testing file uploads in nested array
RDelorier Apr 26, 2017
006a357
fix style
RDelorier Apr 26, 2017
c6df992
Replace value instead of unset
RDelorier Apr 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/Illuminate/Foundation/Testing/Concerns/MakesHttpRequests.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,6 +307,8 @@ protected function extractFilesFromDataArray(&$data)

if (is_array($value)) {
$files[$key] = $this->extractFilesFromDataArray($value);

unset($data[$key]);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace this with $data[$key] = $value;, I think it'll fix your issue.

}
}

Expand Down