[5.4] If there is a withCount, Than also is withSum/withAvg/withMin/withMax

[xuqihua]

No description provided.

[fernandobandeira]

This is actually a breaking change for the withCount method, when no column is passed to withCount it should use * and not id also I don't think it's good to hard code id there, maybe you could try getting the primary key of the model?

This is breaking because count(column) will not count when the column is null, also ppl may be using this on a model that doesn't have the id column...

Also this is missing tests, but it's a nice feature would like to see it into the framework 😄.

Old PR #16815

[xuqihua]

@fernandobandeira
Thank you. I dont know there is old PR.
I have tested it in my project 😂

[fernandobandeira]

We actually should wrap the column name here:

Expression($type.'('.$this->query->getGrammar()->wrap($column).')')

The rest seems fine now 👍

[taylorotwell]

If this is a breaking change we can not merge it into 5.4.

[Numline1]

@taylorotwell Any chance this would make it into 5.5? What changes would be necessary, except the stated defaults (PK or * instead of "id")?

[decadence]

@xuqihua can you make it for 5.5?

[xuqihua]

@decadence
Maybe, but I have used another way to solve such situation。
sub-query is a slow solution

[decadence]

@xuqihua
Yes but sometimes it's acceptable.
Give it a try for 5.5 please.

[xuqihua]

@decadence
okay