Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.3] Fix detach behaviour (BelongsToMany.php) #16144

Closed
wants to merge 5 commits into from
Closed

[5.3] Fix detach behaviour (BelongsToMany.php) #16144

wants to merge 5 commits into from

Commits on Oct 27, 2016

  1. Update BelongsToMany.php 

    Change behaviour of detach. Actually If it receives an empty array or collection it will erase all associations. I believe it should only break all associations if receives no argument.

Code modification checks if any $id argument was given and if it's empty, returns zero, to indicate nothing was detached.
    @asamarcos
    asamarcos authored Oct 27, 2016
    Configuration menu
    Copy the full SHA
    50b4aaf View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2016

  1. Update BelongsToMany.php

    @asamarcos
    asamarcos authored Oct 28, 2016
    Configuration menu
    Copy the full SHA
    857f571 View commit details
    Browse the repository at this point in the history

  2. Update BelongsToMany.php

    @asamarcos
    asamarcos authored Oct 28, 2016
    Configuration menu
    Copy the full SHA
    6cf8b14 View commit details
    Browse the repository at this point in the history

  3. Update BelongsToMany.php

    @asamarcos
    asamarcos authored Oct 28, 2016
    Configuration menu
    Copy the full SHA
    6b6cac7 View commit details
    Browse the repository at this point in the history

  4. Update BelongsToMany.php

    @asamarcos
    asamarcos authored Oct 28, 2016
    Configuration menu
    Copy the full SHA
    f0f4bf7 View commit details
    Browse the repository at this point in the history