-
Notifications
You must be signed in to change notification settings - Fork 11.4k
[5.3] add $default parameter to query builder when() method #15422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/Illuminate/Encryption/composer.json # src/Illuminate/Support/composer.json
allows you to specify a default in the case that the when() $value is false
Looks like composer is having some issues on Travis... Any way to schedule a rebuild on that? |
Do you want to send this to 5.3? |
Ugh, this branch switcher from GH sucks. I'll re-submit. |
@tomschlick I was the reason for all this opening/closing hassle, sorry :) |
No problem haha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally opened in #15421 but @themsaid asked I open it against master
This allows you to specify a default closure to run if the
when()
$value attribute is false.I recently found myself creating a sorting / filtering system with defaults that the user could change. Without this you would have to do all kinds of wackiness to clear the previous where() clause on $value being true.
Here is an example of this in action