[5.2] Add withoutTrashed method to SoftDeletingScope #14805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillkruss
pushed a commit
to tillkruss/framework
that referenced
this pull request
Aug 30, 2016
* Add withoutTrashed method to SoftDeletingScope * Apply StyleCI patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes it's useful to exclude trashed records when
withTrashedscope has been already applied.Let's assume we have some complex list and data returned depends on user role. By default we allow to display all the users also trashed data, but for user with role
Clientwe won't to allow this. So we can either to repeatwithTrashedfor all roles exceptClientor we can just usewithTrashedglobally and then for user with roleClientuse->whereNull('deleted_at'). It would be better to usewithoutTrashedproposed here than manually adding such condition to query.