Skip to content

[5.2] Make Collection unique method to use strict check when comparing keys #14451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[5.2] Make Collection unique method to use strict check when comparing keys #14451

wants to merge 3 commits into from

Conversation

mnabialek
Copy link
Contributor

This was raised in #14449 - in fact I think it should use strict checking in this case by default

@mnabialek
Copy link
Contributor Author

After reconsideration I've added $strict parameter with default to false to not to break existing code, however I would consider to change this parameter to true by default for example in 5.3 branch

@fernandobandeira
Copy link
Contributor

fernandobandeira commented Jul 24, 2016 •
edited
Loading

IMO we should always avoid to change the default behavior of functions on existing releases, i deleted my previous comment on this PR because i thought that probably there's no one expecting this to not be strict mode however better safe than sorry.

@taylorotwell
Copy link
Member

Please send PR for uniqueStrict method to 5.3 branch.

@mnabialek mnabialek mentioned this pull request Aug 6, 2016
Merged
@mnabialek mnabialek deleted the 5.2-unique-strict branch January 1, 2018 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mnabialek @fernandobandeira @taylorotwell