[5.2] Wrap "has" callback in where closure

[wleona3]

So that "orWheres" on the has condition don't have to ALSO be nested in another where closure.

[acasar]

Hmm... Can you give some code example where this is needed?

You can have joins and other clauses in whereHas so we can't nest everything inside where

[taylorotwell]

Closing based on above comment.

[wleona3]

Code such as this:

Model::whereHas('relation', function ($query) {
    $query->where('foo', 'bar');
    $query->orWhere('foo', 'baz');
});

Results in an exists condition like this:
exists (relation.id = model.relation_id and relation.foo = 'bar' or relation.foo = 'baz')

The issue here is that the 'or' statement now always applies. I'd hope that it'd generate something similar to

exists (relation.id = model.relation_id and (relation.foo = 'bar' or relation.foo = 'baz'))

However I can see how to PR doesn't solve this

[acasar]

@wleona3 Thanks for the example. Your fix doesn't work in some cases as mentioned above, but we could implement it more like this: https://github.com/laravel/framework/blob/5.2/src/Illuminate/Database/Eloquent/Builder.php#L1149